#11259: LU decomposition for matrices with exact base rings
------------------------------+---------------------------------------------
   Reporter:  rbeezer         |          Owner:  jason, was
       Type:  enhancement     |         Status:  needs_work
   Priority:  minor           |      Milestone:  sage-4.7.2
  Component:  linear algebra  |       Keywords:            
Work_issues:                  |       Upstream:  N/A       
   Reviewer:                  |         Author:  Rob Beezer
     Merged:                  |   Dependencies:            
------------------------------+---------------------------------------------
Changes (by mraum):

  * status:  needs_review => needs_work


Comment:

 I haven't yet tested this, but from looking at the code I find two things
 that I would ask you to change:
 1. the import statements should not go into the method, but rather to the
 header of the file
 2. the caching is utterly inefficient, when it comes to 'auto'. In case
 you deal with 'auto' pivots, would you mind to first convert it to either
 of the two normal values and than call fetch()? This won't cost much time,
 but it can save space and also prevents you from computing the same thing
 twice.

 You also might want to try to use add_multiple_of_row to make the
 implementation either faster or more readable. Not sure whether you have
 already considered this, but it could be worth a try.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11259#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to