#10793: Matrices can be "constructed" from matrices of wrong dimensions
------------------------------+---------------------------------------------
   Reporter:  vbraun          |          Owner:  jason, was        
       Type:  defect          |         Status:  needs_review      
   Priority:  critical        |      Milestone:  sage-4.7.2        
  Component:  linear algebra  |       Keywords:  sd31              
Work_issues:                  |       Upstream:  N/A               
   Reviewer:  Volker Braun    |         Author:  Andrey Novoseltsev
     Merged:                  |   Dependencies:  #11200, #11552    
------------------------------+---------------------------------------------

Comment(by rbeezer):

 I think that if a rebase is straightforward (ie there is no real change to
 code), then it does not need to be reviewed.  I can't tell here, since the
 rebased patch replaced the old patch.

 No matter - I've applied it and done minimal tests.  All looks good.  I'm
 running all tests right now and then will flip to positive review.

 I'm glad this got fixed.  While doing work on free module morphisms I ran
 into this frequently, where domains and codomains got confused, and so on.
 I'm surprised it survived this long.  Thanks Volker and Andrey for the
 fix!

 Rob

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10793#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to