#11273: Riemann Enhancements: Docs, Exterior, Multiple Spiderweb, Error Testing
--------------------------------------------------+-------------------------
Reporter: evanandel | Owner: burcin
Type: enhancement | Status:
needs_review
Priority: major | Milestone: sage-4.7.2
Component: calculus | Keywords: riemann
map
Work_issues: | Upstream: N/A
Reviewer: Burcin Erocal, Karl-Dieter Crisman | Author: Ethan Van
Andel
Merged: | Dependencies: #8867,
#10792, #10821, #11028
--------------------------------------------------+-------------------------
Comment(by kcrisman):
Here are some more precise remaining comments.
* As text files, you should make sure to include the Trac number in the
commit messages of the first two patches. I recommend just opening them as
text, adding that, and then uploading them again ("replace existing file
of the same name" or whatever). No need to rebase or something like that,
that would be silly when this is so easy to fix.
* The indention of {{{Simple test::}}} and Testing the accuracy of
{{{Riemann_Map::}}} is still not correct. Those should be at the same
level as the {{{TESTS:}}} block, I think.
* In order to make sure we actually we right in closing #8867 and #10945,
there has to be some mention of lambda functions. You said so yourself :)
* I still think that the change in 3 needs to be made, or that test
doesn't make sense. If I'm wrong, just clarify, no big deal.
As to review thus far, I have no problem with patch 2 as long as it passes
tests, and patch 3 is clearly fine except for the issues mentioned above,
which should be fixed.
So now I just need to make sure that the overhaul and new stuff in patch 1
is right :) Though I trust it is. I'm looking forward to this being in and
at this level, even if I don't get to teach complex analysis for a while.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11273#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
