#10635: refactor polynomial_element.pyx factor function
---------------------------------------------------------+------------------
Reporter: was | Owner:
AlexGhitza
Type: enhancement | Status:
positive_review
Priority: minor | Milestone:
sage-4.7.2
Component: basic arithmetic | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Mariah Lenox, William Stein, Simon Spicer | Author:
Christopher Hall
Merged: | Dependencies:
---------------------------------------------------------+------------------
Changes (by spice):
* status: needs_review => positive_review
* reviewer: Mariah Lenox, William Stein => Mariah Lenox, William Stein,
Simon Spicer
Comment:
Yep, looks fine. Test pass, code works, couldn't even find a typo. Note
that this latest patch only sets it up so that if a base ring has a native
{{{_factor_univariate_polynomial()}}} or
{{{_roots_univariate_polynomial()}}} method, then those will be used
instead of the generic {{{factor()}}} and {{{roots()}}} method in
polynomial_element.pyx.
The ring-specific functionality of these two methods still needs to be
moved across to their respective files; to address this I've created patch
#11731.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10635#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
