#11142: clean up sage/misc/hg.py
-----------------------------------+----------------------------------------
   Reporter:  jhpalmieri           |          Owner:  jason        
       Type:  enhancement          |         Status:  needs_review 
   Priority:  minor                |      Milestone:  sage-4.7.2   
  Component:  misc                 |       Keywords:  sd31         
Work_issues:                       |       Upstream:  N/A          
   Reviewer:  Karl-Dieter Crisman  |         Author:  John Palmieri
     Merged:                       |   Dependencies:  #10594       
-----------------------------------+----------------------------------------
Changes (by jhpalmieri):

  * status:  needs_work => needs_review


Old description:

> The attached patch cleans up hg.py in a few ways:
>
>  - it adds a few doctests, although many of them are marked "not tested",
> since otherwise it would try to import or export non-existent patches,
> etc.
>
>  - the function "pager" is rewritten, to use the Mercurial pager
> extension.  This way, any highlighting is preserved when you use
> "hg_sage.diff()" or "hg_sage.log()" with the color extension enabled.
>
>  - the function "color" was added, to disable the Mercurial color
> extension in the notebook.  Otherwise it produces some bad output: try
> putting
>     {{{
> [extensions]
> color =
>     }}}
>  in your .hgrc file, modify some files in the Sage library, and type
> "hg_sage.status()" in      the command line vs. the notebook.
>
> ------
>
> Apply [attachment:trac_11142-sage-hg.v2.patch] and
> [attachment:trac_1142-reviewer.patch].

New description:

 The attached patch cleans up hg.py in a few ways:

  - it adds a few doctests, although many of them are marked "not tested",
 since otherwise it would try to import or export non-existent patches,
 etc.

  - the function "pager" is rewritten, to use the Mercurial pager
 extension.  This way, any highlighting is preserved when you use
 "hg_sage.diff()" or "hg_sage.log()" with the color extension enabled.

  - the function "color" was added, to disable the Mercurial color
 extension in the notebook.  Otherwise it produces some bad output: try
 putting
     {{{
 [extensions]
 color =
     }}}
  in your .hgrc file, modify some files in the Sage library, and type
 "hg_sage.status()" in      the command line vs. the notebook.

 ------

 Apply [attachment:trac_11142-sage-hg.v3.patch] and
 [attachment:trac_1142-reviewer.patch].

--

Comment:

 Okay, here is a new patch.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11142#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to