#10719: Symmetrica does not build on OpenSUSE 11.2 x86_64
------------------------------+---------------------------------------------
Reporter: vbraun | Owner: GeorgSWeber
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.7.2
Component: build | Keywords: library order linker semantics
Work_issues: | Upstream: N/A
Reviewer: Leif Leonhardy | Author: Volker Braun
Merged: | Dependencies:
------------------------------+---------------------------------------------
Changes (by leif):
* status: needs_review => needs_work
* reviewer: => Leif Leonhardy
Comment:
A couple of more or less minor issues:
* Michael Abshoff should be removed from the spkg maintainer list.
* [http://www.symmetrica.de/] is perhaps a more stable upstream link
(currently redirected to [http://www.algorithm.uni-
bayreuth.de/en/research/SYMMETRICA/]).
* `s/sort tp/sort to/` in `SPKG.txt`
* `$CFLAG64` should be quoted in `[ -z $CFLAG64 ]`. (And exporting
`CFLAGS` there is really redundant.)
* Not all user-specified `CFLAGS` should be overridden by Sage's (e.g.
`-O2` should precede `$CFLAGS` in the assignment).
* The exit codes of `patch` (and `cp`) aren't checked. (`makefile` could
also be patched rather than copied over. `SPKG.txt` mentions
`patches/makefile.patch`, though there's only `patches/makefile`.)
* (GNU) `patch` should be added as a dependency.
* `$MAKE -f makefile` is redundant.
* `$SAGE_LOCAL` should be quoted.
* `cp` for installation (library, headers) should use `-p`, otherwise the
current umask could break permissions.
* The new `makefile` removes the `test` target, which builds an
executable functioning as a minimalistic test suite. (The removal also
removes `-lm` completely, such that the changelog entry regarding that no
longer applies.)
The "usual" superfluous trailing semicolon inside the sanity check is ''of
course''^TM^ also there; `[ -z "$SAGE_LOCAL" ]` is also better than
comparing to an empty string.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10719#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
