#11778: p_iter_fork doesn't flush stdout properly
------------------------------+---------------------------------------------
Reporter: johanbosman | Owner: tbd
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.7.2
Component: misc | Keywords: parallel fork stdout
Work_issues: | Upstream: N/A
Reviewer: Leif Leonhardy | Author: Johan Bosman
Merged: | Dependencies:
------------------------------+---------------------------------------------
Comment(by leif):
Replying to [comment:15 johanbosman]:
> Replying to [comment:14 leif]:
> > I'd say a comma there isn't absolutely necessary, but I should have
added periods... (I saw that of course^TM^ ''after'' I had committed my
changes.)
> Have a look at http://en.wikipedia.org/wiki/Comma#Separation_of_clauses
;).
Well, since "which" refers to a single subprocess, it is unambiguous.
(But you're in principle right, omitting the comma might be considered a
bit sloppy, as the clause is non-restrictive from a ''grammatical'' point
of view. I'd say it ''is'' restrictive, or constraining, from a logical
point of view though, as the subprocess wouldn't have been killed in that
situation otherwise, i.e. if it had not taken too long.)
We could also change "''which'' took too long" to "''because'' it took too
long"... :)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11778#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
