#11751: make free_module_generic_pid also work for pid's other then integers
------------------------------+---------------------------------------------
Reporter: mderickx | Owner: jason, was
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.7.2
Component: linear algebra | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author:
Merged: | Dependencies:
------------------------------+---------------------------------------------
Comment(by mderickx):
The patch looks good :). Didn't try it yet how it works with doctests and
yet but at least the code looks reasonable.
If this passes all test, then at least I want something like the following
as a doctest:
{{{
sage: L=K^2
sage: R=L.span([[x,1/x]])
sage: R.basis()[0][0]
x
sage: R.basis()[0][0].parent()
Fraction Field of Univariate Polynomial Ring in x over Rational Field
sage: R=L.span([[x,x^2]])
sage: R.basis()[0][0].parent()
Univariate Polynomial Ring in x over Rational Field
}}}
Since if we are going to look at the parent of one specific element, then
we certainly want that it depends in the right way of the other elements.
A neater way to do this would be to actually store "coefficient_ring" in
the parent, since I think that
{{{
parent.basis()[0][0].parent()
}}}
Is way to many steps removed from parent to actually directly acces from
the code. But this is just nitpicking.
I'm now doctesting your patch.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11751#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
