#9224: Unify sage-test and sage-ptest
---------------------------+------------------------------------------------
   Reporter:  mpatel       |          Owner:  mvngu                             
                                  
       Type:  enhancement  |         Status:  new                               
                                  
   Priority:  minor        |      Milestone:                                    
                                  
  Component:  doctest      |       Keywords:  testlong maketest parallel race 
condition unique doctest directories
Work_issues:               |       Upstream:  N/A                               
                                  
   Reviewer:               |         Author:                                    
                                  
     Merged:               |   Dependencies:                                    
                                  
---------------------------+------------------------------------------------
Changes (by leif):

  * keywords:  => testlong maketest parallel race condition unique doctest
               directories


Comment:

 Replying to [comment:16 jhpalmieri]:
 >  1. If we keep `SAGE_TESTDIR` as a subdirectory of `DOT_SAGE`, we should
 call it `DOT_SAGE/testing/` instead of `DOT_SAGE/tmp/`.  This describes
 the directory better, and the directory can contain timing files, for
 example, which are intended to persist, not be temporary.

 At least for the ''temporary'' files, I think the name of the subdirectory
 should also contain the hostname and the PID of the parent process (just
 like `sage-ptest` now manages this, cf. #9739), to support e.g. running
 `make testlong` simultaneously from different machines sharing the same
 filesystem, i.e., sharing the `DOT_SAGE` directory or whatever
 `SAGE_TESTDIR` might be, and also running different instances of e.g.
 `make testlong` or `sage -t ...` ''on the same machine'' at the same time.

 (At least Dave requested this feature, cf. [comment:ticket:9739:19 his
 comment here] and [comment:ticket:9739:21 here], and
 [comment:ticket:9739:83 my suggestion].)

 Timings should perhaps have their own, persistent directory. Either we
 accept the possibility of race conditions there, or we should add e.g. the
 hostname and the time (the former reasonable anyway), eventually also the
 PID, to the filenames.

 [[BR]]

 >  2. Note that the script `sage-test` creates `SAGE_TESTDIR` as
 `DOT_SAGE/tmp`, and then creates a further subdirectory `tmp` of this.  I
 don't think there is any reason for this subdirectory to exist.

 Yep, that's odd. We have a whole bunch of `tmp` / `temp` subdirectories
 all around.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9224#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to