#11130: Update PARI to version 2.5.0
--------------------------------------------+-------------------------------
   Reporter:  jdemeyer                      |          Owner:  jdemeyer         
                                              
       Type:  defect                        |         Status:  needs_work       
                                              
   Priority:  critical                      |      Milestone:  sage-4.7.2       
                                              
  Component:  packages                      |       Keywords:  pari spkg sd32   
                                              
Work_issues:                                |       Upstream:  N/A              
                                              
   Reviewer:  John Cremona, Jeroen Demeyer  |         Author:  Jeroen Demeyer, 
John Cremona                                   
     Merged:                                |   Dependencies:  #11230, #11234, 
#11321 (install this '''after''' building PARI)
--------------------------------------------+-------------------------------
Changes (by jdemeyer):

  * status:  needs_review => needs_work


Comment:

 John, your patch changes the ''functionality'' of the
 `simon_two_descent()` function by adding a new option ``store_gens``.  I
 have two problems with this:

  1. I think a ticket related to upgrading PARI is not the correct place to
 make such a change (or at least, it should be justified why).
  1. I don't like how `store_gens` changes the output of the function.  The
 name op this option does not imply that the output would be changed.  I
 can agree that you store the saturated points (as before), but why also
 ''return'' the saturated points?  This is a real functional change.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11130#comment:101>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to