#10155: Implementation of the Cyclic Sieving Phenomenon
-----------------------------+----------------------------------------------
Reporter: stumpc5 | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.7.2
Component: combinatorics | Keywords: Cyclic Sieving Phenomenon
Work_issues: | Upstream: N/A
Reviewer: | Author: Christian Stump
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Changes (by chapoton):
* status: needs_review => needs_work
Comment:
This seems good enough. I will soon give a positive review if minor
corrections are made.
1) at start of the patch, before AUTHORS, there is a broken (not complete)
sentence.
2) I am not happy with the name of the procedures.
What about CyclicSieving_find and CyclicSieving_test ?
or CyclicSievingPolynomial and CyclicSievingCheck ?
or some mix of that..
3) You could use R.gen() instead of R.gens()[0] (at least twice)
4) in CyclicSieving, you can use keys to compute n, instead of calling
.keys() again
5) in orbit_decomposition, there misses the OUTPUT: a list of lists, the
orbits under cyc_act acting on L
6) why do you need to import QQ ? because of q-analogues ? coercion may
work with ZZ, maybe..
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10155#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
