#11820: Undo #4777: Remove PARI bug work-around in is_prime_power()
----------------------------------------------+-----------------------------
   Reporter:  aapitzsch                       |          Owner:  AlexGhitza     
       Type:  enhancement                     |         Status:  positive_review
   Priority:  major                           |      Milestone:  sage-4.7.2     
  Component:  basic arithmetic                |       Keywords:                 
Work_issues:                                  |       Upstream:  N/A            
   Reviewer:  Leif Leonhardy, Jeroen Demeyer  |         Author:  André Apitzsch 
     Merged:                                  |   Dependencies:  #11685         
----------------------------------------------+-----------------------------
Changes (by jdemeyer):

  * status:  needs_review => positive_review
  * reviewer:  Leif Leonhardy => Leif Leonhardy, Jeroen Demeyer


Old description:

> The PARI bug mentioned in #4777 is fixed, see ![1].
> So undo #4777 to make {{{is_prime_power()}}} faster.
>
> ![1] [http://pari.math.u-bordeaux.fr/cgi-
> bin/bugreport.cgi?bug=916&archive=yes]
>
> ----
>
> Apply
>  1. [attachment:trac_11820_undo_4777.patch]
>  1. [attachment:trac_11820-beautify_error_message.reviewer.patch]
> to the Sage library.

New description:

 The PARI bug mentioned in #4777 is fixed, see ![1].
 So undo #4777 to make {{{is_prime_power()}}} faster.

 ![1] [http://pari.math.u-bordeaux.fr/cgi-
 bin/bugreport.cgi?bug=916&archive=yes]

 ----

 Apply
  1. [attachment:trac_11820_undo_4777.patch]
  1. [attachment:trac_11820-beautify_error_message.reviewer-v2.patch]
 to the Sage library.

--

Comment:

 I don't why exception strings should have a dot at the end, they most
 commonly do '''not''' have a dot.  New reviewer patch fixing that.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11820#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to