#11830: Problems with Mercurial and utf-8 data in files
------------------------+---------------------------------------------------
Reporter: jdemeyer | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.7.2
Component: scripts | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author: Jeroen Demeyer
Merged: | Dependencies:
------------------------+---------------------------------------------------
Comment(by leif):
Replying to [comment:3 jdemeyer]:
> Replying to [comment:2 leif]:
> > P.S:: The commit message lacks a ticket number... ;-)
>
> True, but a while ago it was decided that ticket numbers were no longer
required on commit messages.
Perhaps my bad, I'm not aware of such an agreement, but I strongly object.
[[BR]]
> Ticket numbers are added automatically by my merger script.
As I already said elsewhere, this ignores the fact that there's sometimes
a tiny period of time between when a patch gets attached to a ticket and
when it gets merged into a release (and this release published).
[[BR]]
> This simplifies the work of the release manager, who no longer has to
complain about missing ticket numbers.
Well, he/she doesn't have to; reviewers IMHO should. Same for
''filenames'' of patches ''not'' containing the ticket number.
(Btw., also the patchbot could complain about things like these, including
missing or misspelled author and reviewer names on a ticket.)
[[BR]]
> It also ensures a common formatting for the ticket number: the commit
message always starts with "Trac #${TICKET_NUMBER}: " which might be
useful for scripts.
That's just a matter of how smart the scripts are, including the merge
scripts themselves.
Besides that I don't like that long form; I also noticed that a couple of
commit messages get this prepended despite already containing the ticket
number, or even starting with it (which they IMHO always should, since a
commit message might reference other tickets as well).
If you want a ''unique'' form (which I'd consider unnecessary because
scripts can easily recognize different, preferably nevertheless
standardized variants), at least ticket numbers shouldn't get duplicated
in the commit messages.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11830#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
