#11716: Remove twisted.persisted.styles import
-------------------------------------------+--------------------------------
Reporter: saraedum | Owner: jason
Type: enhancement | Status: closed
Priority: critical | Milestone: sage-4.7.2
Component: performance | Resolution: fixed
Keywords: sd32 start-up time startup | Work_issues:
Upstream: N/A | Reviewer: Mike Hansen
Author: Julian Rueth | Merged: sage-4.7.2.alpha3
Dependencies: |
-------------------------------------------+--------------------------------
Old description:
> The import of ''twisted.persisted.styles'' takes a significant amount of
> time on sage startup:
> {{{
> $ time ./sage -startuptime|grep twisted.persisted.styles:
> twisted.persisted.styles: 0.093 (sage.all)
>
> real 0m1.422s
> }}}
>
> Most functionality from that module seems not to be used in sage. The
> attached patch removes everything but the needed functionality:
> {{{
> $ time ./sage -startuptime|grep twisted.persisted.styles:
>
> real 0m1.280s
> }}}
>
> ----
>
> Apply [attachment:trac_11716_twisted_persisted_styles.patch] to the Sage
> library.
New description:
The import of ''twisted.persisted.styles'' takes a significant amount of
time on sage startup:
{{{
$ time ./sage -startuptime|grep twisted.persisted.styles:
twisted.persisted.styles: 0.093 (sage.all)
real 0m1.422s
}}}
Most functionality from that module seems not to be used in sage. The
attached patch removes everything but the needed functionality:
{{{
$ time ./sage -startuptime|grep twisted.persisted.styles:
real 0m1.280s
}}}
----
Apply only [attachment:trac_11716_twisted_persisted_styles.proper.patch]
to the Sage library.
--
Comment(by leif):
I've attached a `*.proper.patch`, which is identical except that I removed
the "garbage" before "`# HG changeset patch`", i.e., I deleted the first
line "`exporting patch:`", since Jeroen's current merger rejects such
patches.
For now, please make sure all your patches start with "`# HG changeset
patch`", i.e., have it on the first line without any preceding messages or
whatever.
I've relaxed that in ''my version'' of the merger, but Jeroen and maybe
others are likely to use his more restrictive one.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11716#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
