#11866: zshell prompt
-----------------------------+----------------------------------------------
Reporter: malb | Owner:
Type: defect | Status: positive_review
Priority: minor | Milestone: sage-4.7.2
Component: scripts | Keywords:
Work_issues: | Upstream: N/A
Reviewer: John Palmieri | Author: Martin Albrecht
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Changes (by jhpalmieri):
* priority: major => minor
* reviewer: => John Palmieri
* status: needs_review => positive_review
Old description:
> This sucks:
>
> {{{
> malb@road:~ $ env | grep "SHELL="
> SHELL=/bin/zsh
> malb@road:~ $ sage -sh
> ...
>
> Bypassing shell configuration files ...
>
> SAGE_ROOT=/home/malb/Sage/current\n(sage subshell) \h:\W \u$
> }}}
>
> i.e., the prompt is all wrong, compared to:
>
> {{{
> malb@road:/opt/sage-4.7.2.alpha3-prerelease/local/bin $
> /opt/sage-4.7.2.alpha3-prerelease/sage -sh
>
> Starting subshell with Sage environment variables set.
> Be sure to exit when you are done and do not do anything
> with other copies of Sage!
>
> Bypassing shell configuration files ...
>
> SAGE_ROOT=/opt/sage-4.7.2.alpha3-prerelease
> (sage subshell) road:/opt/sage-4.7.2.alpha3-prerelease/local/bin malb$
> }}}
>
> The attached patch fixes this.
>
> '''Apply''' [attachment:trac11866_proper_zsh_prompt.patch] to the
> root/scripts directory, not the normal Sage repository.
New description:
This sucks:
{{{
malb@road:~ $ env | grep "SHELL="
SHELL=/bin/zsh
malb@road:~ $ sage -sh
...
Bypassing shell configuration files ...
SAGE_ROOT=/home/malb/Sage/current\n(sage subshell) \h:\W \u$
}}}
i.e., the prompt is all wrong, compared to:
{{{
malb@road:/opt/sage-4.7.2.alpha3-prerelease/local/bin $
/opt/sage-4.7.2.alpha3-prerelease/sage -sh
Starting subshell with Sage environment variables set.
Be sure to exit when you are done and do not do anything
with other copies of Sage!
Bypassing shell configuration files ...
SAGE_ROOT=/opt/sage-4.7.2.alpha3-prerelease
(sage subshell) road:/opt/sage-4.7.2.alpha3-prerelease/local/bin malb$
}}}
The attached patch fixes this.
'''Apply''' [attachment:trac11866_proper_zsh_prompt.patch] to the scripts
repository, not the normal Sage repository.
--
Comment:
This looks good and it works in my (brief) testing. See #10822 and #11790
for patches which already include this particular fix. It's probably
easiest to get this one merged, and then rebase the others with respect to
this one. But if you use zsh, I would be happy to hear your input on
#10822.
I think that since it seems to work, and since we came up with the same
change completely independently, this can be given a positive review.
(Note that the "scripts" repository and the "root" repository are
different. This should be applied to the scripts repository. I've
changed the ticket description to clarify this.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11866#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
