#11861: Saturation of ideals
-----------------------------------------+----------------------------------
   Reporter:  dangtuanhiep               |          Owner:  malb                
   
       Type:  defect                     |         Status:  needs_work          
   
   Priority:  trivial                    |      Milestone:  sage-4.7.2          
   
  Component:  commutative algebra        |       Keywords:  saturation, ideal, 
sd34
Work_issues:                             |       Upstream:  N/A                 
   
   Reviewer:  Luis Felipe Tabera Alonso  |         Author:  Hiep Dang           
   
     Merged:                             |   Dependencies:                      
   
-----------------------------------------+----------------------------------

Comment(by malb):

 Replying to [comment:3 lftabera]:
 > Nice addition, I will use this method a lot.
 >
 > Some comments:
 >
 > - I cannot apply the patch cleanly agains Sage 4.7.1 Which version are
 you using?
 >
 > - I think that having two separate functions is inefficient. Computing
 saturations    is very expensive. Many people computing the saturation
 index will probably want the saturation ideal as well. In this case they
 would need to compute the saturation twice. I think it is better to add
 only one method that returns the answer from Singular. A tuple whose first
 element is the saturation ideal and the second element the saturation
 index.

 Otherwise, {{{@cached_method}}} is your friend :)

 > - I suggest to improve the documentation. Some indication that `arg` is
 an ideal, what is the saturation of two ideals and the saturation index.

 Agred, the parameters are not documented at all, {{{INPUT:}}} block etc.

 > - I am not sure how to deal with the rings that Singular does not
 understand. We will probably get a TypeError exception on those. Probably
 a NonImplementedError would make more sense here.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11861#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to