#11885: call function in sage.libs.mpmath.utils doesn't handle 
parent=parent(float)
------------------------------+---------------------------------------------
   Reporter:  benjaminfjones  |          Owner:  burcin                      
       Type:  defect          |         Status:  needs_work                  
   Priority:  major           |      Milestone:  sage-4.7.2                  
  Component:  symbolics       |       Keywords:  mpmath call parent precision
Work_issues:                  |       Upstream:  N/A                         
   Reviewer:  Burcin Erocal   |         Author:  Benjamin Jones              
     Merged:                  |   Dependencies:                              
------------------------------+---------------------------------------------
Changes (by burcin):

  * status:  needs_review => needs_work
  * reviewer:  => Burcin Erocal


Comment:

 Thanks for the patch. It looks good, though I have minor suggestions:
  * this needs to be doctested
  * using
 {{{
 try:
     prec = parent.prec()
 except AttributeError:
     pass
 }}}
 might be faster than performing a test with `hasattr()` first, then
 looking up the `prec()` method again.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11885#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to