#11760: 'sage-location' shouldn't "initialize" .pc (pkg-config) files more than
once
-----------------------------+----------------------------------------------
Reporter: leif | Owner:
Type: defect | Status: positive_review
Priority: blocker | Milestone: sage-4.7.2
Component: scripts | Keywords: pkgconfig libpng Duplicate
definition SAGE_ROOT
Work_issues: | Upstream: N/A
Reviewer: John Palmieri | Author: Leif Leonhardy
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Comment(by leif):
Replying to [comment:23 jhpalmieri]:
> Replying to [comment:18 leif]:
> > Btw., with re.escape() typical paths get much longer... 8&
>
> Yes, but you don't have to ever look at them, do you? Just pass them on
to `re`.
Of course, but longer strings take longer to compile... ;-)
> (If you feel like adding a comment about re.escape, in case someone else
works on this, go ahead. No need for further review in that case.)
It seems `sub()` is indeed ''slower'' than `str.replace()` (about 7:4 in
CPU time), so it's not worth using it there instead. Users won't notice
any difference anyway I think; I was just curious. (And it's hardly worth
updating the patch or providing a new one just to update the comment on
that.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11760#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
