#5155: Fix doctests and methods that want write access to $SAGE_LOCAL
------------------------+---------------------------------------------------
   Reporter:  mabshoff  |          Owner:  jdemeyer   
       Type:  defect    |         Status:  needs_work 
   Priority:  critical  |      Milestone:  sage-4.7.3 
  Component:  scripts   |       Keywords:             
Work_issues:            |       Upstream:  N/A        
   Reviewer:            |         Author:  Mike Hansen
     Merged:            |   Dependencies:  #11926     
------------------------+---------------------------------------------------

Comment(by jdemeyer):

 Replying to [comment:14 jhpalmieri]:
 > A few quick comments:
 >
 >  - you have a typo in line 93, "eyactly"
 No idea how that happened...

 >  - on line 583, `# optional - qepcad, note "algeraic" [sic]`, this is
 not the way to format an optional doctest: it will only run if you do
 "sage -t -optional-only=qepcad,not,algeraic,sic" or something like that.
 Very true, thanks!

 > For the scripts patch:
 >
 >  - why not apply os.path.abspath to SAGE_ROOT?
 Because `SAGE_ROOT` is already canonicalized by `realpath` at the top of
 that file:
 {{{
 SAGE_ROOT     = os.path.realpath(os.environ['SAGE_ROOT'])
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5155#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to