#11311: engine="pdflatex" in view is ignored
-----------------------------------+----------------------------------------
   Reporter:  saliola              |          Owner:  jason, was             
       Type:  defect               |         Status:  needs_info             
   Priority:  major                |      Milestone:  sage-4.7.2             
  Component:  graphics             |       Keywords:  latex, pdflatex, days30
Work_issues:                       |       Upstream:  N/A                    
   Reviewer:  Karl-Dieter Crisman  |         Author:  Franco Saliola         
     Merged:                       |   Dependencies:                         
-----------------------------------+----------------------------------------

Old description:

> The view command states that the pdflatex argument is deprecated and that
> one should use the engine argument instead.
>
> But if one sets engine="pdflatex", it is overwritten, and so one
> currently needs to use the deprecated pdflatex option.
>
> ----
>
> Apply [attachment:trac_11311-rebased.patch].

New description:

 The view command states that the pdflatex argument is deprecated and that
 one should use the engine argument instead.

 But if one sets engine="pdflatex", it is overwritten, and so one currently
 needs to use the deprecated pdflatex option.

 ----

 Apply [attachment:trac_11311-rebased.patch],
 [attachment:trac_11311-ref.patch].

--

Comment(by jhpalmieri):

 I'm attaching a referee patch which removes the code duplication referred
 to above.

 Karl-Dieter: the program "sage-open", as defined in sage/misc/viewer.py,
 should be used to open the output file.  Before the patch here, it was
 called with `output_file` set to "sage.dvi" or something like that.  After
 the patch, it is called with `output_file` set to "sage.pdf".  So any
 difference in what program is being used is because this is producing a
 pdf file, not a dvi file.

 I'd like to change this from "needs info" to "positive review".   Is that
 okay?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11311#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to