#9562: Add M4RIE to Sage
-------------------------------------------+--------------------------------
Reporter: malb | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-5.0
Component: packages | Keywords: m4ri, sd32
Work_issues: | Upstream: N/A
Reviewer: Paul Zimmermann, Simon King | Author: Martin Albrecht
Merged: | Dependencies: #11757 #4260
-------------------------------------------+--------------------------------
Changes (by SimonKing):
* status: needs_review => positive_review
Comment:
It seems to me that all previous complaints are addressed in the new spkg
and patches.
In particular, if one has opened the spkg, starts a sage shell and does
./spkg-install, then ./spkg-check works, with all tests. passing.
hg status in the spkg is fine, and SPKG.txt looks fine as well (except a
typo in the last line, should be "split from", not "split form" - but
please leave that error, since the Gods don't like perfection among the
mortals :)
Moreover, `sage -coverage sage/matrix/matrix_mod2e_dense.pyx` is OK.
All doc tests pass as well, and I think the original problems with t2 had
been dealt with.
Thus, I hope all participants agree that it is a positive review!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9562#comment:126>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
