#11119: ECL 11.1.1 fails on Cygwin
--------------------------------------------------------------------+-------
Reporter: mhansen |
Owner: tbd
Type: defect |
Status: closed
Priority: major |
Milestone: sage-4.7.3
Component: cygwin |
Resolution: fixed
Keywords: |
Work_issues:
Upstream: Fixed upstream, but not in a stable release. |
Reviewer: Karl-Dieter Crisman, Reg Burgess, François Bissey
Author: Dmitrii Pasechnik, Mike Hansen, Karl-Dieter Crisman |
Merged: sage-4.7.3.alpha0
Dependencies: |
--------------------------------------------------------------------+-------
Changes (by kcrisman):
* reviewer: Karl-Dieter Crisman, Reg Burgess => Karl-Dieter Crisman, Reg
Burgess, François Bissey
Comment:
Disagree. Sure, we should start adding this to spkgs, and yes it is good
that #11884 should have it changed since no one noticed it otherwise, but
it is just too onerous to keep adding requirements like this when even
someone pretty savvy about builds like François didn't notice this -
particularly because the ECL package, like '''many''' other packages,
didn't have it before! It's not like people are intentionally trying to
remove checking of exit codes.
Like a lot of other things, if we ever want Sage to actually improve, we
have to strike a balance between these kinds of things. In this case,
under what circumstances would the exit code make a difference? Only if
someone updates the spkg... which is being dealt with at #11884, at least
I hope so.
Unless you are suggesting that we should immediately make blocker tickets
for every spkg which has patches without checking the exit code of `patch`
:) but given our testing regimen, doing it as we notice it seems just
fine, especially as not everyone has the expertise to do this quickly.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11119#comment:47>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
