#11886: fix scipy so it builds on OS X Lion
-------------------------------------------+--------------------------------
   Reporter:  jhpalmieri                   |          Owner:  tbd               
                          
       Type:  defect                       |         Status:  positive_review   
                          
   Priority:  major                        |      Milestone:  sage-4.7.2        
                          
  Component:  packages                     |       Keywords:  scipy spkg 
upgrade update lion darwin 11    
Work_issues:                               |       Upstream:  Fixed upstream, 
but not in a stable release.
   Reviewer:  Mike Hansen, Leif Leonhardy  |         Author:  John Palmieri     
                          
     Merged:                               |   Dependencies:                    
                          
-------------------------------------------+--------------------------------
Changes (by jhpalmieri):

  * status:  needs_review => positive_review


Comment:

 Looks good to me.  The only change I might consider in addition is this:
 {{{
 #!diff
 diff --git a/SPKG.txt b/SPKG.txt
 --- a/SPKG.txt
 +++ b/SPKG.txt
 @@ -33,6 +33,11 @@ BSD terms. See http://www.scipy.org/Lice
     The ones added in the scipy-0.9.p0 spkg (#11886) were all taken from
     (unstable) upstream, so can presumably be removed once we upgrade to
     a new stable version.
 + * To do: in spkg-install, should we only remove the previous
 +   installation after successfully building the new one?  That is, is
 +   it safe to move 'rm -rf "$SAGE_LOCAL"/lib/python/site-packages/scipy'
 +   so it is between 'python setup.py build' and 'python setup.py
 +   install'?

  == Changelog ==

 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11886#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to