#11575: Update PolyBoRi to release 0.8.0
-------------------------------+--------------------------------------------
Reporter: AlexanderDreyer | Owner: AlexanderDreyer
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-pending
Component: packages | Keywords:
Work_issues: cython-0.15.1 | Upstream: None of the above - read trac
for reasoning.
Reviewer: Martin Albrecht | Author: Alexander Dreyer
Merged: | Dependencies: #11574, #9138
-------------------------------+--------------------------------------------
Comment(by AlexanderDreyer):
Indeed, the line in question was buggy. So I corrected it and added a
suitable doctest:
{{{
#!diff
diff --git a/sage/rings/polynomial/pbori.pyx
b/sage/rings/polynomial/pbori.pyx
--- a/sage/rings/polynomial/pbori.pyx
+++ b/sage/rings/polynomial/pbori.pyx
@@ -4516,7 +4516,9 @@
0
sage: p.reduce(I)
x1*x2*x3 + x2
-
+ sage: p.reduce([])
+ x0*x1*x2 + x0*x1*x3 + x0*x2*x3 + x2
+
.. note::
If this function is called repeatedly with the same I then
@@ -4535,7 +4537,7 @@
"""
from polybori import red_tail
if not I:
- return g
+ return self
if PY_TYPE_CHECK(I, BooleanPolynomialIdeal):
I = I.gens()
first = I[0]
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11575#comment:136>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
