#9054: create a class for basic function_field arithmetic for Sage
-----------------------------------------------------------------------------------------------+
Reporter: was
| Owner: was
Type: enhancement
| Status: needs_work
Priority: major
| Milestone: sage-4.8
Component: algebra
| Resolution:
Keywords:
| Work_issues:
Upstream: N/A
| Reviewer: Maarten Derickx, Julian Rueth
Author: William Stein, Robert Bradshaw, Maarten Derickx, Moritz
Minzlaff, Julian Rueth | Merged:
Dependencies: #9094, #11751, #9138
|
-----------------------------------------------------------------------------------------------+
Changes (by mderickx):
* status: needs_review => needs_work
Comment:
Ok these are the results from reading trough you patches:
Why did you make some_elements in function_field.py return only one
element? This number should be at least two (and preferable even at least
3) since else a lot of tests in TestSuite(F).run() will be meaningless
with just one element because one element is always equal to itself for
example!
If you make vector_space a cached method then why don't you change
{{{
self._vector_space = (V, from_V, to_V)
return self._vector_space
}}}
to
{{{
return (V, from_V, to_V)
}}}
This code is in two places.
In function_field_order.py there is a typo in the sentence "the function
field in which this iss an order."
Why did you remove:
{{{
if is_Ideal(gens):
gens = gens.gens()
}}}
in function_field_order.py. I suspect the code was there to make the (not
doctested) use case of:
{{{
sage: K.<x> = FunctionField(QQ)
sage: O=K.maximal_order()
sage: I=O.ideal(x)
sage: O.ideal(I)
}}}
since you should be able to make an ideal with input an ideal.
For the rest your combination patch looks very nice. Also good that you
made the documentation quality so much higher. If you either answer the
above questions with the right arguments or if you change them back it
seems that we can finally have function fields in sage!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9054#comment:67>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
