#11781: Conversion from Zmod element to padic element raises "not a power of the
same prime" incorrectly, add conversion from residue_field
-------------------------+--------------------------------------------------
   Reporter:  robharron  |          Owner:  roed              
       Type:  defect     |         Status:  positive_review   
   Priority:  minor      |      Milestone:  sage-4.8          
  Component:  padics     |       Keywords:  padics, conversion
Work_issues:             |       Upstream:  N/A               
   Reviewer:  David Roe  |         Author:  Robert Harron     
     Merged:             |   Dependencies:                    
-------------------------+--------------------------------------------------
Changes (by newvalueoldvalue):

  * reviewer:  => David Roe
  * author:  => Robert Harron


Old description:

> Since mpz_cmp_ui returns 0 if equality holds, wrong 'if' condition was
> being used to check if Zmod element was in the right characteristic. Fix
> this in padic_ZZ_pX_CR_element.pyx and padic_ZZ_pX_CA_element.pyx.
>
> Also, enhancement: allow conversion from element of the residue_field of
> self (this really only affects unramified extensions).

New description:

 Since mpz_cmp_ui returns 0 if equality holds, wrong 'if' condition was
 being used to check if Zmod element was in the right characteristic. Fix
 this in padic_ZZ_pX_CR_element.pyx and padic_ZZ_pX_CA_element.pyx.

 Also, enhancement: allow conversion from element of the residue_field of
 self (this really only affects unramified extensions).

 '''Apply'''
 
[attachment:trac_11781_padics_conversion_Zmod_fix_and_res_field_enhance.v2.patch]

--

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11781#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to