#12002: avoid race conditions when creating directories - scripts
------------------------+---------------------------------------------------
Reporter: jdemeyer | Owner: leif
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-4.8
Component: scripts | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author: Jeroen Demeyer
Merged: | Dependencies:
------------------------+---------------------------------------------------
Comment(by jhpalmieri):
In sage-ptest, the code
{{{
#!python
if os.path.isdir(TMP): # used to be os.path.exists(TMP)
shutil.rmtree(TMP)
os.makedirs(TMP)
}}}
will now fail if TMP exists but is not a directory. Is this okay? I
wouldn't mind just deleting TMP regardless, in which case the code should
probably be
{{{
#!python
try:
shutil.rmtree(TMP)
except ....
}}}
or perhaps
{{{
#!python
shutil.rmtree(tmp, ignore_errors=True)
}}}
Otherwise it looks okay to me.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12002#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
