#11784: Add more sanity checks to Galois Field constructor
--------------------------------+-------------------------------------------
Reporter: lftabera | Owner: lftabera
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.8
Component: basic arithmetic | Keywords: beginner
Work_issues: | Upstream: N/A
Reviewer: Johan Bosman | Author: Luis Felipe Tabera Alonso
Merged: | Dependencies:
--------------------------------+-------------------------------------------
Changes (by johanbosman):
* status: needs_review => positive_review
* reviewer: => Johan Bosman
Comment:
Replying to [comment:5 lftabera]:
> Thanks for realizing this.
>
> I have updated the patch according to the python guidelines. The only
one I have not followed is the limit of 79 characters that is surpassed in
some exception messages and is not followed for similar code along the
Sage library. But I can also change this.
It would indeed be better, but I think it is okay like this.
> I have changed the exception style to Exception("message") style and
added a dot in Exception messages.
This is probably much better than Exception, "message" indeed, which
everyone uses. :).
The patch looks good now, works, and passes all tests.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11784#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
