#11952: Fix conversion Python -> PARI
--------------------------+-------------------------------------------------
   Reporter:  jdemeyer    |          Owner:  was                                
           
       Type:  defect      |         Status:  positive_review                    
           
   Priority:  major       |      Milestone:  sage-4.8                           
           
  Component:  interfaces  |       Keywords:                                     
           
Work_issues:              |       Upstream:  N/A                                
           
   Reviewer:              |         Author:  Jeroen Demeyer                     
           
     Merged:              |   Dependencies:  #11130, #11321, #11854, #11891, 
#11890, #11836
--------------------------+-------------------------------------------------
Changes (by robertwb):

  * status:  needs_review => positive_review


Comment:

 Looks good to me (pending all doctests passing) and much cleaner. I
 checked the derivatives in lseries_ell.py to higher precision, the new
 values are correct.

 Nit:

 {{{
 if PyBool_Check(s):
     return self.PARI_ONE if s else self.PARI_ZERO
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11952#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to