#9138: Categories for all rings
----------------------------------------------------+-----------------------
Reporter: jbandlow | Owner: nthiery
Type: defect | Status:
positive_review
Priority: major | Milestone:
sage-pending
Component: categories | Resolution:
Keywords: introspection, categories for rings | Work_issues:
Upstream: N/A | Reviewer: Volker
Braun
Author: Simon King | Merged:
Dependencies: #11761. To be merged with #11900 |
----------------------------------------------------+-----------------------
Changes (by SimonKing):
* dependencies: To be merged with #11900 => #11761. To be merged with
#11900
Old description:
> Introspection is failing on polynomial rings:
> {{{
> sage: R.<x> = QQ[]
> sage: R.su<tab>
> R.sum R.summation
> R.summation_from_element_class_add
> sage: R.sum?
> Object `R.sum` not found.
> sage: R.sum()
> ---------------------------------------------------------------------------
> AttributeError Traceback (most recent call
> last)
> }}}
>
> This is because polynomial rings do not yet set their category properly:
> {{{
> sage: QQ[x]._test_category()
> ------------------------------------------------------------
> Traceback (most recent call last):
> ...
> AssertionError: category of self improperly initialized
> }}}
>
> See http://groups.google.com/group/sage-
> devel/browse_thread/thread/4780192a11a8b591 for more discussion.
>
> Many other rings are not properly initialised as well. The aim of this
> ticket is to change that.
>
> Apply [attachment:9138_flat.patch]
>
> See #11900 for a follow-up fixing some speed regressions.
New description:
Introspection is failing on polynomial rings:
{{{
sage: R.<x> = QQ[]
sage: R.su<tab>
R.sum R.summation
R.summation_from_element_class_add
sage: R.sum?
Object `R.sum` not found.
sage: R.sum()
---------------------------------------------------------------------------
AttributeError Traceback (most recent call
last)
}}}
This is because polynomial rings do not yet set their category properly:
{{{
sage: QQ[x]._test_category()
------------------------------------------------------------
Traceback (most recent call last):
...
AssertionError: category of self improperly initialized
}}}
See http://groups.google.com/group/sage-
devel/browse_thread/thread/4780192a11a8b591 for more discussion.
Many other rings are not properly initialised as well. The aim of this
ticket is to change that.
Apply [attachment:9138_flat_new_cython.patch]
See #11900 for a follow-up fixing some speed regressions.
--
Comment:
Since #11761 is already merged, I was rebasing the patch relative to it.
The change is trivial, though: #11761 adds the line
{{{
msg = None
}}}
into sage/rings/polyomial/pbori.pyx, so that one of my hunks did not apply
anymore. I did test that afterwards `sage -t
sage/rings/polynomial/pbori.pyx` still passes.
I hope that the rebase is trivial enough, so that I can preserve the
positive review.
Apply 9138_flat_new_cython.patch
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9138#comment:120>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
