#12036: improve doctest coverage of gsl/interpolation.pyx from 0% to 100%
-----------------------------------+----------------------------------------
Reporter: was | Owner: jason, jkantor
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-4.8
Component: numerical | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Karl-Dieter Crisman | Author: William Stein
Merged: | Dependencies:
-----------------------------------+----------------------------------------
Changes (by was):
* status: needs_info => needs_review
Comment:
Adding a {{{TestSuite(s).run()}}} run would be nice, but it will fail,
since there is no support for pickling in this code. Adding this to
reference manual would be nice too, but that's other work.
Regarding __setitem__, though it is perhaps interesting that this is
supported, I doubt most people would even think to want to change the
points that they are interpolating through after they create the spline.
Basically, I want modifications to code that I doctest to be minimal --
I'm adding tests to get the coverage score to 90% for sage-5.0. I don't
want to introduce bugs. Say what you will about this patch, it can't
introduce bugs because it only changes docstrings. I would like it
refereed on those merits. Keep in mind that I'm not introducing a *new*
class into Sage for the first time. If that were the case, then having
TestSuite, pickling support, etc., would be absolutely required.
Opening and resolving a new ticket to do everything you suggest will be
easier now that this file has 100% coverage, since at least when adding
some new code, you'll have some tests to run to reduce the chances the new
code doesn't break things.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12036#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
