#12058: Mercurial should not enable pager by default
------------------------+---------------------------------------------------
   Reporter:  jdemeyer  |          Owner:  tbd       
       Type:  defect    |         Status:  needs_info
   Priority:  blocker   |      Milestone:  sage-4.8  
  Component:  packages  |       Keywords:            
Work_issues:            |       Upstream:  N/A       
   Reviewer:            |         Author:            
     Merged:            |   Dependencies:            
------------------------+---------------------------------------------------

Comment(by jdemeyer):

 Replying to [comment:1 kini]:
 > Please explain what is very bad about this. Any problems caused by the
 pager extension being enabled in `$SAGE_LOCAL/etc/mercurial/hgrc` would
 equally be caused by the pager extension being enabled in `$HOME/.hgrc`,
 which you will agree is not under our control.
 True, but `$SAGE_LOCAL/etc/mercurial/hgrc` is not under ''my'' control.  I
 personally do not want a pager to be enabled, so I do ''not'' enable the
 pager extension in ''my'' `.hgrc`.  It's true that I have the environment
 variable `PAGER` set, but that is used for many things (like e.g.
 `EDITOR`), so I don't want to disable it just for Sage.

 > Even if we did set a pager, it is set to only apply to the commands
 annotate, cat, diff, log, glog, and qdiff. I question why one would need
 to use these in a script in the first place, as they are by nature
 interactive commands.
 There are 6 occurences of `hg diff` in the `$SAGE_ROOT/local/bin/*`
 scripts, so I disagree.

 > This was introduced by #11121, not #10594
 Wrong, this was introduced in #10594.  It is the Mercurial spkg which
 writes `$SAGE_LOCAL/etc/mercurial/hgrc`.  On #11121 I have made a comment
 that I did not want the pager extension to be enabled by default.

 > As Volker pointed out on sage-devel, an even better way to avoid this is
 to set the HGPLAIN environment variable.
 True, but I think that is an orthogonal issue.  Even if we do use
 `HGPLAIN` in scripts, I think we still should not enable the pager
 extension by default.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12058#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to