#12039: Doctest sage.categories.action
------------------------------+---------------------------------------------
   Reporter:  roed            |          Owner:  mvngu       
       Type:  defect          |         Status:  needs_review
   Priority:  major           |      Milestone:  sage-4.8    
  Component:  doctest         |       Keywords:              
Work_issues:                  |       Upstream:  N/A         
   Reviewer:  Florent Hivert  |         Author:  David Roe   
     Merged:                  |   Dependencies:  #12048      
------------------------------+---------------------------------------------
Changes (by hivert):

  * reviewer:  => Florent Hivert


Comment:

 A followup for my last remark. The idea of {{{LazyFormat}}} is to be able
 to
 print counter examples in the error message for {{{TestSuite}}} when a
 property is
 wrong, without drastically slowing down the tests. I would therefore
 suggest
 to replace
 {{{
 #!python
 tester.assertTrue(self(a, self(b, v)) == self(a*b, v),
                   LazyFormat("Multiplication is not associative")%(()))
 }}}
 by
 {{{
 #!python
 tester.assertTrue(self(a, self(b, v)) == self(a*b, v),
     LazyFormat("Multiplication is not associative: %s*(%s*%s) !=
 (%s*%s)*%s")%(a,b,v,a,b,v))
 }}}
 And similarly for the other one.

 Also in the category directory, the usage is to place the example in the
 subdirectory examples. An action isn't really a category, but I think it
 would
 be good to have all the examples there. Moreover, don't forget to add your
 very nice example in the reference manual (file:
 {{{doc/en/reference/categories.rst}}}).

 By the way: thanks a lot for writing all this nice documentation.

 Florent

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12039#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to