#12170: Genus computation (using singular) and _singular_ object for function
filed
----------------------------------+-----------------------------------------
Reporter: sydahmad | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-5.0
Component: algebraic geometry | Keywords: function field, genus,
singular
Work_issues: | Upstream: N/A
Reviewer: | Author: Syed Ahmad Lavasani
Merged: | Dependencies: #9054
----------------------------------+-----------------------------------------
Changes (by sydahmad):
* status: needs_work => needs_review
Comment:
I addressed cache_method, reducing calls and using integral polynomial. I
also got rid of the line in is_RationalFunctionField which was making the
documentation invalid. About the name and place of definition of
is_RationalFunctionField, I think the name is appropriate because it shows
that we are asking about the type of the object and not the rationality of
the function field. For the same reason, because it's asking about the
type of the object and not one of its attribute, doesn't it make sense to
remain outside, like is_FunctionField (though we don't have a cat (yet!)).
Anyways, if there's a unanimous decision about its name and its place of
definition, I'll apply it. But if it is defined in the !FunctionField
class it will be only:
{{{
def is_RationalFunctionField(self):
return False;
}}}
and in the !RationalFunctionField class:
{{{
def is_RationalFunctionField(self):
return True;
}}}
We can also, get rid of it, but I think it improves the readability of the
code.
And sorry about two patches. I initiated my queue after the first
submission and now hg doesn't let me rollback.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12170#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
