#12134: is_planar(set_pos=True) doesn't work with small graphs
-----------------------------+----------------------------------------------
Reporter: brunellus | Owner: jason, ncohen, rlm
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.8
Component: graph theory | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Nathann Cohen | Author:
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Comment(by ncohen):
> If we suppose that the function planarity.is_planar is only accessed by
generic_graph.is_planar, then there shouldn't be any loops at this moment,
because the generic_graph function makes a graph simple first. I'm not
sure if that's true, but I must admit I didn't wrote the code with this in
mind -- I just didn't notice that disconected case was handled by previous
change. :-)
Hmmmm... Well, anyway that's not such a horrible problem :-)`
> I plan to work with this more. For example, it seems to me that teaching
_triangulate how to handle disconnected cases shouldn't be very hard, as
allowing embedding of multigraphs. I guess this can be usefull for #6236.
+1 for the idea, and +1 for your relationship with Sage's source code. The
lad knows a lot of stuff I do not know myself, but its education is still
lacking on many points.
By the way, you should add your name to the "Authors" field of the ticket,
lest the guy above (the release manager) .set the ticket back to
"needs_work"
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12134#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
