#12243: Girth of a graph fails for non-integer vertices
-----------------------------+----------------------------------------------
Reporter: rbeezer | Owner: jason, ncohen, rlm
Type: defect | Status: positive_review
Priority: minor | Milestone: sage-4.8
Component: graph theory | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Nathann Cohen | Author: Rob Beezer
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Changes (by ncohen):
* status: needs_review => positive_review
* reviewer: => Nathann Cohen
Comment:
Hellooooo !!
Well, this patch does the trick for this implementation and fixed the bug,
hence it's good to go !
On the other hand, this kind of things will really need to be rewritten
decently in Cython... To give an idea, the work done by this Python
function is more or less (actually, less) than the work done by the
"diameter" function, which has been rewritten not so long ago.
{{{
sage: g = graphs.OddGraph(7)
sage: %timeit g.diameter()
5 loops, best of 3: 155 ms per loop
}}}
Well, thank you very much for this bugfix though `:-)`
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12243#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
