#9826: Memory corruption in polynomial complex_roots() method
-----------------------------------+----------------------------------------
   Reporter:  hlaw                 |          Owner:  somebody                  
            
       Type:  defect               |         Status:  needs_review              
            
   Priority:  major                |      Milestone:  sage-5.0                  
            
  Component:  commutative algebra  |       Keywords:  complex root, polynomial, 
finite field
Work_issues:                       |       Upstream:  N/A                       
            
   Reviewer:                       |         Author:  Johan Bosman, Michael 
Orlitzky        
     Merged:                       |   Dependencies:  #11900                    
            
-----------------------------------+----------------------------------------
Changes (by newvalueoldvalue):

 * cc: mjo (added)
  * milestone:  sage-4.8 => sage-5.0
  * dependencies:  => #11900
  * author:  Johan Bosman => Johan Bosman, Michael Orlitzky


Comment:

 The fix works and makes sense to me (positive review for that). I've added
 a doctest (needs review), and rebased the original patch against
 4.8.alpha5.

 Unfortunately, something is wrong with exceptions at the moment:

 {{{
 sage: (a*x).complex_roots()
 ERROR: An unexpected error occurred while tokenizing input
 The following traceback may be corrupted or invalid
 The error message is: ('EOF in multi-line statement', (1731, 0))
 ...
 }}}

 and that's fixed by Simon King's patch in #11900, so I've added a
 dependency there. The milestone update is to match #11900.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9826#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to