#12246: Wiener index without dictionnary
-----------------------------+----------------------------------------------
   Reporter:  dcoudert       |          Owner:  jason, ncohen, rlm
       Type:  PLEASE CHANGE  |         Status:  needs_review      
   Priority:  major          |      Milestone:  sage-5.0          
  Component:  graph theory   |       Keywords:                    
Work_issues:                 |       Upstream:  N/A               
   Reviewer:                 |         Author:                    
     Merged:                 |   Dependencies:  #12244            
-----------------------------+----------------------------------------------

Comment(by ncohen):

 Helloooooooo !!!

 I think I had the same problem a looong time ago, and I probably chosed
 the nasty way out. What happens when you cite the paper while not defining
 them in the same function ? Are the links broken, or fo they redirect
 toward the other function's references ?
 The release manager is wise but his wrath is terrifying. In particular, he
 does not like warnings, so we should avoid that `:-D`
 By the way (and I know that the difference in runtime is very small), it
 is easier to check whether a graph is connected than to count the number
 of connected components. So in the process, could you replace
 ``self.connected_components_number() == 1`` by ``self.is_connected()`` ?

 If the references are broken when you cite in one method the references
 defined in another one, I'd say that duplicating them and changing the
 name (add a number at the end, or a letter) is not thaaaaaat bad anyway
 `:-)`

 Nathann

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12246#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to