#12179: Binomial of integer (mod n) returns integer
----------------------------------------------------------------------------------+
Reporter: scotts
| Owner: AlexGhitza
Type: defect
| Status: needs_work
Priority: major
| Milestone: sage-4.8
Component: basic arithmetic
| Keywords: binomial coefficient modulo sd35
Work_issues: rebase on top of #11417, reST formatting issue, improve
efficiency | Upstream: N/A
Reviewer: Colton Pauderis, Johan Bosman, Marco Streng
| Author: Sam Scott
Merged:
| Dependencies: #11417
----------------------------------------------------------------------------------+
Comment(by mstreng):
Replying to [comment:9 scotts]:
> I definitely agree, the changes I was proposing were to simply try and
return a more sensible type.
>
> Since I am new to sage, I was trying to keep as much of the existing
algorithm intact, so that it wouldn't have any unexpected behaviour. For
example, currently it seems that sage uses Peri to calculate the usual
binomial coefficient. So I wasn't sure if the implementation for modulo n
would belong here.
That sounds sensible, this is a bugfix patch and the inefficiency is not
introduced by your patch. So if you don't want to, you don't have to
improve the speed. However, since you're editing anyway, you might as
well. It's up to you. The other issues
* documentation that does not build correctly
* a conflicting patch has already been merged
do need to be resolved though.
For the first issue, after building Sage, use {{{sage -docbuild reference
html}}} to rebuild the documentation and see if all the changed
documentation looks good (in this case, replacing : by :: will probably be
enough).
As for the second issue, you should not write two independent patches
editing the same part of a file. They can't be applied after each other,
because the second-to-be-applied can't find the piece of code that it
should change. You should write your patch for #12179 on top of a copy of
Sage that has #11417 applied.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12179#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
