#10895: add qitensor spkg (tensors for quantum information)
-------------------------------------+--------------------------------------
Reporter: dstahlke | Owner: tbd
Type: enhancement | Status: needs_work
Priority: major | Milestone:
Component: optional packages | Keywords: quantum spkg tensor
sd35.5
Work_issues: various issues to fix | Upstream: N/A
Reviewer: Paul Zimmermann | Author: Dan Stahlke
Merged: | Dependencies:
-------------------------------------+--------------------------------------
Changes (by newvalueoldvalue):
* status: needs_review => needs_work
* reviewer: => Paul Zimmermann
* work_issues: documentation to fix => various issues to fix
* author: dstahlke => Dan Stahlke
Comment:
thanks Dan. A few comments:
* the SPKG.txt file only mentions version 0.1, not version 0.8
* the documentation on http://www.stahlke.org/dan/qitensor/doc/index.html
is for Python, not for
Sage. In particular the output we get from Sage is different, for
example:
{{{
sage: from qitensor import qubit
sage: ha = qubit('a')
sage: hb = qubit('b')
sage: (ha * hb).array()
|a,b>
[0]
[0]
[-]
[0]
[0]
}}}
which differs from the first example in
http://www.stahlke.org/dan/qitensor/doc/examples/slices.html
* you have added a 3rd item (c) in the original 2-clause BSD license, with
the consequence that
it is no longer a 2-clause BSD license. Please fix that.
* I tried the tests and some of them failed (with sage-4.8.alpha6):
{{{
The following tests failed:
sage -t "qitensor-0.8/src/qitensor/array.py"
sage -t "qitensor-0.8/src/qitensor/atom.py"
sage -t "qitensor-0.8/src/qitensor/circuit.py"
sage -t "qitensor-0.8/src/qitensor/space.py"
Total time for all tests: 38.5 seconds
}}}
* finally some documentation and doctests are missing (here for
{{{circuit.py}}}):
{{{
tiramisu% ../../../sage -coverage circuit.py
----------------------------------------------------------------------
circuit.py
SCORE circuit.py: 0% (0 of 3)
Missing doctests:
* cphase(h1, h2):
* cnot(h1, h2):
* max_entangled(h1, h2):
}}}
Paul Zimmermann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10895#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
