#11073: remove the spkg/base repo!
---------------------------+------------------------------------------------
Reporter: jhpalmieri | Owner: jdemeyer
Type: enhancement | Status: needs_work
Priority: blocker | Milestone: sage-5.0
Component: build | Keywords: scripts base hg
Work_issues: | Upstream: N/A
Reviewer: | Author: Volker Braun, Jeroen Demeyer
Merged: | Dependencies: sage-4.8.alpha6
---------------------------+------------------------------------------------
Changes (by was):
* status: needs_review => needs_work
Comment:
COMMENTS:
1. In this code (and anything similar?):
{{{
17 cd "$SAGE_ROOT/spkg/base"
18 rm -rf .hg* json_bundle.py stdint.h_Solaris9 sage-* text-*
*.sh
}}}
can we have an error check after the cd, before "rm -rf", since if
something went wrong (even a control-c at the wrong moment, or the
spkg/base directory is already gone!), then the "rm -rf" *will* cause some
serious pain, e.g., deleting the .hg repo from SAGE_ROOT. Any time I see
an "rm -rf" in a script I'm very paranoid. This is the sort of situation
where Python would be better.
2. Many people -- e.g., me on the seemingly dozens of machines I have
Sage installed on -- will have a "sage" script that is from before this
patch. That script will *not* be upgraded when we upgrade our Sage
install, since that script is in local/bin/ (say), not in {{{SAGE_ROOT}}}
(and it need not be a symlink). That older script explicitly calls
"local/bin/sage-sage", so it will now be totally broken, since this ticket
deletes sage-sage. For this reason, I think it is absolutely essential
that sage-sage not be deleted. The sage-sage script needs to remain, but
could either be a 1-liner that calls {{{$SAGE_ROOT/spkg/bin/sage}}} *or*
it could produce a nice useful error message explaining that the user must
update their sage script by copying over the one from SAGE_ROOT, and edit
the path, or create a symbolic link.
3. As far as I can tell, I'm happy with everything else about the new
scripts added 33 hours ago. They fix the issue I reported on sage-devel.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11073#comment:78>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
