#11614: Make Cython libcpp usable
------------------------------------------+---------------------------------
Reporter: vbraun | Owner: jason
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.8
Component: misc | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Jeroen Demeyer, John Perry | Author: Volker Braun
Merged: | Dependencies:
------------------------------------------+---------------------------------
Changes (by john_perry):
* status: needs_review => positive_review
* reviewer: Jeroen Demeyer => Jeroen Demeyer, John Perry
Comment:
All tests passed! While I'm not an expert in Cython, what I see of the
code makes sense, too. (& thanks for illustrating the use of !`string`.)
I'm giving it a positive review, but there are two points I want to ask
about (& which perhaps should prevent positive review, but I'm not sure):
1. You should probably change this in the comments:
{{{
Compare whith !``other!``.
}}}
That should be "with" not "whith". :-)
2. The format opening the file is not quite in conformance with the
format Jeroen requested. There is no list of authors, and the copyright
notice is not quite the same. It's close enough that I'm okay with it, &
I've seen other files that don't follow this pattern. Nevertheless, I
should point it out.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11614#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
