#11073: remove the spkg/base repo!
--------------------------------------------+-------------------------------
Reporter: jhpalmieri | Owner: jdemeyer
Type: enhancement | Status: needs_review
Priority: blocker | Milestone: sage-5.0
Component: build | Keywords: scripts base hg
Work_issues: | Upstream: N/A
Reviewer: John Palmieri, William Stein | Author: Volker Braun,
Jeroen Demeyer
Merged: | Dependencies: sage-4.8.alpha6
--------------------------------------------+-------------------------------
Comment(by jhpalmieri):
I think it's very nice to be able to point the app at any Sage directory.
It seems easy to avoid breaking that feature, so if not here, then we
should have a follow-up ticket which tries `spkg/bin/sage-env` and if that
doesn't exist, then it uses `local/bin/sage-env`. Can we just do
something like this?
{{{
#!diff
diff --git a/sage/ext/mac-app/start-sage.sh b/sage/ext/mac-app/start-
sage.sh
--- a/sage/ext/mac-app/start-sage.sh
+++ b/sage/ext/mac-app/start-sage.sh
@@ -38,7 +38,8 @@ cd /tmp/sage-mac-app || exit 1
# Set (i.e. "source") SAGE_ROOT and all the other environment settings
echo Setting environment variables >> "$SAGE_LOG"
-. ./spkg/bin/sage-env >> "$SAGE_LOG" 2>> "$SAGE_LOG"
+. ./spkg/bin/sage-env >> "$SAGE_LOG" 2>> "$SAGE_LOG" || \
+. ./local/bin/sage-env >> "$SAGE_LOG" 2>> "$SAGE_LOG"
export SAGE_ROOT
# Mac OS X app bundles are *intended* to be moved around, and/or given
away
}}}
Should we fix this here or on a followup?
jdemeyer: you're right, I missed that patch. I read it and thought it
made sense, but then forgot about it and didn't apply it.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11073#comment:102>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
