#12172: R doctest starts X11 on OSX
-----------------------------------+----------------------------------------
Reporter: vbraun | Owner: mvngu
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: doctest | Keywords: R r-project graphics OSX
X11
Work_issues: | Upstream: N/A
Reviewer: Karl-Dieter Crisman | Author: John Palmieri
Merged: | Dependencies:
-----------------------------------+----------------------------------------
Changes (by kcrisman):
* reviewer: => Karl-Dieter Crisman
Comment:
The patch looks ok, modulo my usual having to look up shell syntax.
(Trifle annoying that someone forgot to update the version number in the
GPL listing, but I'm not going to mess with that since it wasn't done on
the upgrade.)
The problem is that I can't test whether it fixes the problem, really.
With Sage 4.8:
{{{
$./sage -t devel/sage/sage/interfaces/r.py
sage -t "devel/sage/sage/interfaces/r.py"
[9.7 s]
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 9.7 seconds
}}}
Even though I have the offending file!
{{{
$ ls /usr/include/X11/
CallbackI.h IntrinsicP.h VarargsI.h Xfuncproto.h Xthreads.h
Composite.h Object.h Vendor.h Xfuncs.h Xtos.h
CompositeP.h ObjectP.h VendorP.h Xlib.h Xtrans
ConstrainP.h PM X.h XlibConf.h Xutil.h
Constraint.h PassivGraI.h X10.h Xlibint.h Xw32defs.h
ConvertI.h RectObj.h XF86keysym.h Xlocale.h Xwindows.h
Core.h RectObjP.h XKBlib.h Xmd.h Xwinsock.h
CoreP.h ResConfigP.h XWDFile.h Xmu
ap_keysym.h
CreateI.h ResourceI.h Xalloca.h Xos.h bitmaps
DECkeysym.h SM Xarch.h Xos_r.h
cursorfont.h
EventI.h SelectionI.h Xatom.h Xosdefs.h dri
HPkeysym.h Shell.h Xauth.h Xpoll.h extensions
HookObjI.h ShellI.h Xaw XprintAppUtil fonts
ICE ShellP.h Xcms.h XprintUtil keysym.h
ImUtil.h StringDefs.h Xcursor Xproto.h
keysymdef.h
InitialI.h Sunkeysym.h Xdefs.h Xprotostr.h xpm.h
Intrinsic.h ThreadsI.h Xdmcp.h Xregion.h
IntrinsicI.h TranslateI.h Xft Xresource.h
}}}
So the best I can do is to say that it doesn't seem to break anything...
Well, I'm going to see if I can break graphics by changing to this spkg.
I'll report back momentarily.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12172#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
