#11634: Base Polyhedron on PPL (by default)
---------------------------+------------------------------------------------
Reporter: vbraun | Owner: mhampton
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-5.0
Component: geometry | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author: Volker Braun
Merged: | Dependencies: #12159, #11429
---------------------------+------------------------------------------------
Changes (by mhampton):
* status: needs_review => needs_info
Comment:
I'm a little confused by the above numerical noise issue. After changing
so that the patch would apply, the doctest failed. If I switch it to
{{{
sage: filled_poly.axes_width()
0.8...
}}}
then it works. I'm not sure if the "0.800..." makes sense on some other
system or not.
Apart from that I think this all looks good. There is one other doctest
failure in integral_points.pyx resulting from the Python switch to 2.7,
line 688 needs to be changed to
{{{
OverflowError: Python int too large to convert to C long
}}}
instead of
{{{
OverflowError: long int too large to convert to int
}}}
With those changes I would be happy to give a positive review.
I haven't looked at #11429 and #12159 by themselves, but it would be nice
to get this ticket into sage-5.0. I don't have a lot of time in the
coming weeks but if Andrey can't review those I would try to check them
out too.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11634#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
