#12068: Numerator for symbolic expression shouldn't use maxima
------------------------------------------------------------------+---------
Reporter: hivert |
Owner: hivert
Type: enhancement |
Status: positive_review
Priority: major |
Milestone: sage-5.0
Component: symbolics |
Keywords: numerator, denominator
Work_issues: |
Upstream: N/A
Reviewer: Burcin Erocal, Florent Hivert, Karl-Dieter Crisman |
Author: Florent Hivert, Burcin Erocal
Merged: |
Dependencies:
------------------------------------------------------------------+---------
Comment(by hivert):
Hi Karl-Dieter,
Replying to [comment:12 kcrisman]:
> The changes to the previous patch seem fine, docs are good, tests pass.
In fact, it's a very nice patch.
Thanks !
> The only problem I spied is in the last hunk:
{{{
- ``self`` -- the symbolic expression converting from
- ``target`` -- (default None) the symbolic expression
}}}
> is too far indented. If you're going to fix all of this stuff, you
might as well make these at the same indentation level as INPUT, such as
in the second-to-last hunk.
> In fact, I'm attaching a reviewer patch to fix this.
Should't someone review your trivial reviewer patch before putting
positive review ? Anyway, It is an obvious patch and I did review it. So I
confirm your positive review.
> I wonder if there is a more 'obvious' name for `normalize` that could be
an alias... anyway, not for this ticket. Assuming that Burcin has no
objections, positive review other than this.
In every CAS I used, I've always been confused by simplify, normal,
combine... I guess Sage isn't an exception.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12068#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
