#12161: Make Sage App on Mac work right all the time on OS X Lion
------------------------------+---------------------------------------------
Reporter: kcrisman | Owner: tbd
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: distribution | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Georg S. Weber | Author: Ivan Andrus
Merged: | Dependencies:
------------------------------+---------------------------------------------
Changes (by newvalueoldvalue):
* reviewer: Ivan Andrus => Georg S. Weber
* author: Georg S. Weber => Ivan Andrus
Comment:
Replying to [comment:9 kcrisman]:
> How should this be reviewed? It sounds like Georg is the author here
(any reason that we don't "export" in the actual patch? I assume that in
the .sh file that doesn't matter or something?)
It's already exported in sage-env. If it wasn't then it wouldn't be a
problem.
> There is also the weird thing about one of the posters on the
ask.sagemath question actually having IPython installed in his 'usual'
install, yet getting that error.
It might be related to mismatching PATH and PYTHON_PATH
> Anyway, do the author and reviewer think this is enough for positive
review? It would be really, really good to be able to merge this quickly
and then post some beta binaries for newbies to test - maybe even
mentioning this at the ask.sagemath question which started it all. Not
having this work consistently in 5.0 would be bad news.
Indeed.
Replying to [comment:10 GeorgSWeber]:
> Hi,
>
> from a mere "formal/technical" point of view, I would be happy naming
Ivan the "author" and myself then "reviewing" it ;-)
Fine by me.
> As for the commit message,
>
> "trac #12161: work around some PATH issue, when using the Terminal on OS
X 10.7 Lion, on first start of Sage for a new user"
>
> might be an alternative choice.
To be fair, at the time the patch had a rather nonsensical commit message
which I have since changed. I'm happy to change it again if desired.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12161#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
