#12371: The graph_decompositions/ code seems to have bounds issues
----------------------------+-----------------------------------------------
Reporter: Snark | Owner: jason, ncohen, rlm
Type: defect | Status: needs_work
Priority: major | Milestone: sage-5.0
Component: graph theory | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author:
Merged: | Dependencies:
----------------------------+-----------------------------------------------
Comment(by ncohen):
> Well, you seemed eager to use "correct types", and signed/unsigned char
didn't seem good enough, so I changed the rest of the code in that
direction :-)
Well, the thing with "char" is that it has a "meaning", it represents
characters, and that's why there is a difference on your architecture.
What I mean by using char is actually "a 8-bits integer", which can be
unsigned at times. But what is the point of saving 3 bytes on an integer
counter ?
> Whatever gets applied, as long as it works, is ok for me.
+1
> (PS: you didn't comment on point 2, which might be an issue if
sizeof(int) isn't what you expect)
Well, I said it would make sense to move its argument to int32_t. Isn't
that what you meant ?
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12371#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
