#11386: Add a bracelet combinatorial class
------------------------------+---------------------------------------------
Reporter: DanielRecoskie | Owner: nthiery
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-5.0
Component: combinatorics | Keywords: sage-combinat combinatorics
bracelet
Work_issues: | Upstream: N/A
Reviewer: | Author: Daniel Recoskie
Merged: | Dependencies:
------------------------------+---------------------------------------------
Changes (by ncohen):
* status: needs_review => needs_work
Comment:
Hellooooo !!
Some remarks :
* This patch needs some documentatin. It would be nice to have a
definition of what bracelets are at the top of the document, and an
explanation of what the methods do.
* You also put tests in some of them, but all the methods should have
at least one.
* The GenB and CheckRev methods should also be renamed "the Sage way",
that is lower case with underscores. It would theoretically be gen_b and
check_rev but these names are not very explicit either. That actually is
not a very bad problem for GenB as it is (I believe) the name commonly
used in the litterature. It seems this method is for internal use only (it
is called by __iter__) and so it would be nice to make it a private method
(that is rename it to _gen_b for instance) if the user is not meant to
call it directly.
* I have no idea what checkrev does `^^;`
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11386#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
