#9714: Graph(..., format='incidence_matrix') doesn't work with graphs that have
loops, but G.incidence_matrix() does.  So?
-----------------------------+----------------------------------------------
   Reporter:  was            |          Owner:  jason, ncohen, rlm
       Type:  defect         |         Status:  needs_review      
   Priority:  minor          |      Milestone:  sage-5.0          
  Component:  graph theory   |       Keywords:                    
Work_issues:                 |       Upstream:  N/A               
   Reviewer:  Nathann Cohen  |         Author:                    
     Merged:                 |   Dependencies:                    
-----------------------------+----------------------------------------------
Changes (by ncohen):

  * reviewer:  => Nathann Cohen


Comment:

 Helloooooooooooooooo !!!

 I find a bit weird that this code deals with -1 and 1 entries for
 *undirected* graphs, but well... `^^;`

 Anyway, here is a very small patch that just avoid some unnecessary
 computations.

 I give a positive review to your patch, and you can review mine if you
 have some time `:-)`

 Nathann

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9714#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to